fix(richtext-lexical): use copy of @lexical/markdown that does not install @lexical/code #9382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9378
We’ve found out that @lexical/markdown imports cannot be reliably dynamically imported by Node.js for an unknown reason. Frequently, Node.js simply exits before the dynamic import is done.
We’re suspecting the reason for this to be its dependency on @lexical/code that installs prism.
This will not only (hopefully) fix the import issue, but also reduce the bundle size & compilation speed of richtext-lexical.