fix(db-postgres): joins with versions and hasMany relationship #9370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanRibbens
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
I think we can merge this and continue to iterate on what we talked about. update and delete can support joins as an additional PR. For versions, since nothing is being stored on the saved document the version has no control on the join data so this is okay to omit. That is different from relationships where depth can be used and it is okay because the relationship reference is stored on the version.
|
🚀 This is included in version v3.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes errors when having joins with versions +drafts on
hasMany: truerelationships.Removes
joinQueryoverhead if we don't need it for the current operation. Right now, in all adapters we support joins only forfind,findOne, andqueryDrafts.Fixes #9369