Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): invalid permissions passed to group and named tab sub-fields #9366

Merged
merged 17 commits into from
Nov 20, 2024

Conversation

AlessioGr
Copy link
Member

@AlessioGr AlessioGr commented Nov 19, 2024

Fixes #9363

This fixes the following issues that caused fields to be either hidden, or incorrectly set to readOnly in certain configurations:

  • In some cases, permissions were sanitized incorrectly. This PR rewrites the sanitizePermissions function and adds new unit tests
  • after a document save, the client was receiving unsanitized permissions. Moving the sanitization logic to the endpoint fixes this
  • Various incorrect handling of permissions in our form state endpoints / RenderFields

@jacobsfletch jacobsfletch changed the title fix: invalid permissions passed to group and named tab sub-fields fix(ui): invalid permissions passed to group and named tab sub-fields Nov 19, 2024
@AlessioGr AlessioGr merged commit c67291d into main Nov 20, 2024
56 checks passed
@AlessioGr AlessioGr deleted the fix/invalid-permissions-for-tabs-and-groups-subfields branch November 20, 2024 20:03
Copy link

🚀 This is included in version v3.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lexical editor forcibly in readonly mode
2 participants