Skip to content

fix(db-mongodb): potential errors in sanitizeRelationshipIDs with ref being a non object #9292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

r1tsuu
Copy link
Member

@r1tsuu r1tsuu commented Nov 18, 2024

What?

Fixes potential errors when passed to sanitizeRelationships ref could potentially be a non object (for example string) because of having in the database data in old structure.

"Cannot create property 'a' on string 'B'",

Why?

Necessary particularly for the migration script, as it migrates everything including versions that can have outdated data.

How?

Ensures passed ref is an object.

@r1tsuu r1tsuu merged commit 665b353 into main Nov 18, 2024
58 checks passed
@r1tsuu r1tsuu deleted the fix/old-data-sanitize-relations branch November 18, 2024 14:10
Copy link
Contributor

🚀 This is included in version v3.0.0-beta.135

kendelljoseph pushed a commit that referenced this pull request Feb 21, 2025
…ref` being a non object (#9292)

### What?
Fixes potential errors when passed to `sanitizeRelationships` `ref`
could potentially be a non object (for example `string`) because of
having in the database data in old structure.
```
"Cannot create property 'a' on string 'B'",
``` 

### Why?
Necessary particularly for the migration script, as it migrates
everything including versions that can have outdated data.

### How?
Ensures passed `ref` is an `object`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants