Field is set to nullable in types when the required option is true and an admin condition is configured.

[bouchaala-sabri]

Describe the Bug

When a field of a relationship type is marked as required, but an admin condition is present, the generated types sets the field to nullable.
Admin UI and API validation will return an error if condition none fulfilled but the generated types set the field as optional.

Link to the code that reproduces this issue

https://github.com/bouchaala-sabri/payload

Reproduction Steps

• Create 2 collections A and B
• Collection A have a field type "relationship" of B
• Set it to required have and admin condition, you can set it the condition to "true" , "false" or any boolean condition. The bug happens in all cases.

Example

Collection Post

import type { CollectionConfig } from 'payload'

export const postsSlug = 'posts'

export const PostsCollection: CollectionConfig = {
  slug: postsSlug,
  admin: {
    useAsTitle: 'title',
  },
  fields: [
    {
      name: 'title',
      type: 'text',
    },
    {
      name: 'category',
      type: 'relationship',
      relationTo: 'categories',
      required: true,
      admin: {
        condition: (data) => true,
      },
      label: 'Segment',
    },
  ],
  versions: {
    drafts: true,
  },
}

Collection Categories

import type { CollectionConfig } from 'payload'

export const CategoriesCollection: CollectionConfig = {
  slug: 'categories',
  admin: {
    useAsTitle: 'name',
  },
  fields: [{ name: 'name', type: 'text', required: true }],
}

Generated types

export interface Post {
  id: string;
  title?: string | null;
  category?: (string | null) | Category;
  updatedAt: string;
  createdAt: string;
  _status?: ('draft' | 'published') | null;
}

Which area(s) are affected? (Select all that apply)

Not sure

Environment Info

Payload: 3.0.0-beta.134
next: 15.0.0
node: v22.10.0

[qgwr32]

If condition returns false, no relationship must be specified, therefore the field is nullable.
Looks fine to me.

[bouchaala-sabri]

@qgwr32 In my real case, the condition is related to a another required fields, for example a propriety have a country and a city, both required and the city will not be shown if no country was set. I tested it in both UI and API and there is no case were a propriety can be created without a city, whatever the condition is.

[qgwr32]

@bouchaala-sabri I get what you are saying, payload cannot however deduce that relationship as it does not know what condition actually depends on.