Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using nodemailerAdapter with mock email (ethereal) - ethereal data is logged multiple times w/ diff data #9226

Open
PatrikKozak opened this issue Nov 15, 2024 · 2 comments
Labels
created-by: Payload team status: needs-triage Possible bug which hasn't been reproduced yet

Comments

@PatrikKozak
Copy link
Contributor

Describe the Bug

Only happens in dev mode - ethereal data is only output once when running in prod (next build && next start)

Attached below is an example output when running pnpm dev email-nodemailer:

Image

Note: The emails are only sent to the first instance of the new ethereal account out of the 4 instances logged in the console

Link to the code that reproduces this issue

pnpm dev email-nodemailer

Reproduction Steps

  1. Run pnpm dev email-nodemailer
  2. Watch the console output from the createMockAccount() function that is called when using nodemailerAdapter() w/o any args

Which area(s) are affected? (Select all that apply)

area: core, Not sure

Environment Info

Payload: v3.0.0-beta.130
Copy link

Please add a reproduction in order for us to be able to investigate.

Depending on the quality of reproduction steps, this issue may be closed if no reproduction is provided.

Why was this issue marked with the invalid-reproduction label?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We prefer a link to a public GitHub repository created with create-payload-app@beta -t blank or a forked/branched version of this repository with tests added (more info in the reproduction-guide).

To make sure the issue is resolved as quickly as possible, please make sure that the reproduction is as minimal as possible. This means that you should remove unnecessary code, files, and dependencies that do not contribute to the issue. Ensure your reproduction does not depend on secrets, 3rd party registries, private dependencies, or any other data that cannot be made public. Avoid a reproduction including a whole monorepo (unless relevant to the issue). The easier it is to reproduce the issue, the quicker we can help.

Please test your reproduction against the latest version of Payload to make sure your issue has not already been fixed.

I added a link, why was it still marked?

Ensure the link is pointing to a codebase that is accessible (e.g. not a private repository). "example.com", "n/a", "will add later", etc. are not acceptable links -- we need to see a public codebase. See the above section for accepted links.

Useful Resources

@BlainMaguire
Copy link
Contributor

I think the issue might be with this line:

} else if ('transportOptions' in emailConfig && emailConfig.transportOptions) {

If there are no transportOptions set in the emailConfig, it will always call createMockAccount and clutter the logs. createMockAccount likely only needs to be called once when initialising the transport.

@denolfe denolfe removed the v3 label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Payload team status: needs-triage Possible bug which hasn't been reproduced yet
Projects
None yet
Development

No branches or pull requests

3 participants