Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

richtext-lexical: HTML convert does not apply target _blank to new tab links #8569

Closed
GeekPro101 opened this issue Oct 5, 2024 · 1 comment · Fixed by #8571
Closed

richtext-lexical: HTML convert does not apply target _blank to new tab links #8569

GeekPro101 opened this issue Oct 5, 2024 · 1 comment · Fixed by #8571
Labels

Comments

@GeekPro101
Copy link
Contributor

Link to reproduction

No response

Describe the Bug

(Fixed in v3)
Image

Generates the following link:
<a href="https://google.com" rel="noopener noreferrer">google.com</a>

Issue lies in:

return `<a href="${href}"${rel}>${childrenText}</a>`

To Reproduce

Create a document with a richtext-lexical richtext editor + htmlConverter
Create a link and tick new tab option (see above)
Observe no _blank attribute in

Payload Version

v2.15.0

Adapters and Plugins

db-mongdb, bundler-webpack, richtext-lexical

@GeekPro101 GeekPro101 added status: needs-triage Possible bug which hasn't been reproduced yet v2 labels Oct 5, 2024
@github-actions github-actions bot removed the status: needs-triage Possible bug which hasn't been reproduced yet label Oct 7, 2024
@GermanJablo
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants