WIP: Make session initialization implicit #364
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A session is now initialized by generating keys and sharing them out of band. The semantics of the protocol are otherwise unchanged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #363
A session is now initialized by generating keys and sharing them out
of band.
A POST request pushes data to a subdirectory, conventially defined by the a public key.
I'm still running into one issue regarding Payjoin v1 backwards compatibility, that the
peek()function does not work when both the Original PSBT and the Payjoin PSBT share the same subdirectory. This is because the peek function returns the data in that directory if it is not empty, which it won't be because it just saved an Original PSBT. I can fix this by skipping that check and only awaiting a new internal pub-sub message indicating that the value was updated.