Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API.pause_all() should only try to pause active downloads #24

Closed
lzzy12 opened this issue Oct 10, 2019 · 2 comments
Closed

API.pause_all() should only try to pause active downloads #24

lzzy12 opened this issue Oct 10, 2019 · 2 comments
Assignees
@pawamoy
Labels
bug Something isn't working module:api

Comments

@lzzy12
Copy link

lzzy12 commented Oct 10, 2019

Currently, if I call the pause_all method, it tries to pause all the downloads, including already finished or paused downloads. Hence it returns False even if a single download has finished, failed, already paused
@pawamoy
Copy link
Owner

pawamoy commented Oct 10, 2019

Indeed, it does not make sense to try to pause already completed/failed/paused downloads. Will come up with a fix asap.

@pawamoy
Copy link
Owner

pawamoy commented Oct 10, 2019

This should be fixed in version 0.3.0 thanks to this commit: 0bf2209

@pawamoy pawamoy self-assigned this Oct 10, 2019
@pawamoy pawamoy added bug Something isn't working module:api labels Oct 10, 2019
@pawamoy pawamoy closed this as completed Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawamoy pawamoy

Labels
bug Something isn't working module:api
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pawamoy @lzzy12