Skip to content

Commit dee1213

Browse files
committed
fix quality ready v1.0.5
1 parent 7e9c06d commit dee1213

File tree

6 files changed

+9
-6
lines changed

6 files changed

+9
-6
lines changed

README.md

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
![build-and-test](https://github.com/pavlobu/deskreen/workflows/build%20and%20test/badge.svg)
1111
![codecov-generate](https://github.com/pavlobu/deskreen/workflows/codecov/badge.svg)
1212
[![codecov](https://codecov.io/gh/pavlobu/deskreen/branch/master/graph/badge.svg?token=fqfBlyXT5O)](https://codecov.io/gh/pavlobu/deskreen)
13+
![platform](https://img.shields.io/badge/platform-Windows%20%7C%20MacOS%20%7C%20Linux-lightgrey)
1314

1415
### ▶️ [Deskreen Youtube channel](https://www.youtube.com/channel/UCyiTK98gjDKGNNjUk9ynzxQ) (video tutorials, demos, use cases for Deskreen day to day usage)
1516

app/client/src/features/PeerConnection/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ export default class PeerConnection {
5959

6060
screenSharingSourceType: string | undefined = undefined;
6161

62-
videoQuality = VideoQuality.Q_AUTO;
62+
videoQuality = VideoQuality.Q_100_PERCENT;
6363

6464
videoAutoQualityOptimizer: VideoAutoQualityOptimizer;
6565

app/client/src/features/PeerConnection/peerConnectionHandlePeer.spec.ts

+4-2
Original file line numberDiff line numberDiff line change
@@ -178,13 +178,14 @@ describe('peerConnectionHandlePeer callback', () => {
178178

179179
describe('when quality is AUTO and when video quality optimizer requests GOOD quality', () => {
180180
it('should call .send with proper data message', () => {
181+
peerConnection.videoQuality = VideoQuality.Q_AUTO;
181182
peerConnectionHandlePeer(peerConnection);
183+
182184
peerConnection.peer?.emit('stream');
183185

184186
jest.advanceTimersByTime(2000);
185187
peerConnection.videoAutoQualityOptimizer.goodQualityCallback();
186188

187-
expect(peerConnection.videoQuality).toBe(VideoQuality.Q_AUTO);
188189
expect(peerConnection.peer?.send).toBeCalledWith(
189190
prepareDataMessageToChangeQuality(1)
190191
);
@@ -205,13 +206,14 @@ describe('peerConnectionHandlePeer callback', () => {
205206

206207
describe('when quality is AUTO and when video quality optimizer requests HALF quality', () => {
207208
it('should call .send with proper data message', () => {
209+
peerConnection.videoQuality = VideoQuality.Q_AUTO;
208210
peerConnectionHandlePeer(peerConnection);
211+
209212
peerConnection.peer?.emit('stream');
210213

211214
jest.advanceTimersByTime(2000);
212215
peerConnection.videoAutoQualityOptimizer.halfQualityCallbak();
213216

214-
expect(peerConnection.videoQuality).toBe(VideoQuality.Q_AUTO);
215217
expect(peerConnection.peer?.send).toBeCalledWith(
216218
prepareDataMessageToChangeQuality(0.5)
217219
);

app/package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "deskreen",
33
"productName": "Deskreen",
4-
"version": "1.0.4",
4+
"version": "1.0.5",
55
"description": "Deskreen turns any device into a secondary screen for your computer",
66
"main": "./main.prod.js",
77
"author": {

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "deskreen",
33
"productName": "Deskreen",
4-
"version": "1.0.4",
4+
"version": "1.0.5",
55
"description": "Deskreen turns any device into a secondary screen for your computer",
66
"scripts": {
77
"build": "yarn build-client && yarn build-main && yarn build-renderer",

0 commit comments

Comments
 (0)