signaling-server-python not compatible with websockets v14

[SirNate0]

From their changelog:

The following aliases in the websockets package were switched to the new asyncio implementation:

from websockets import connect, unix_connext
from websockets import broadcast, serve, unix_serve

If you’re using any of them, then you must follow the upgrade guide immediately.

Alternatively, you may stick to the legacy asyncio implementation for now by importing it explicitly:

from websockets.legacy.client import connect, unix_connect
from websockets.legacy.server import broadcast, serve, unix_serve

In particular, when a client attempts to connect, the server will fail:

Listening on 127.0.0.1:8000
server listening on 127.0.0.1:8000
connection open
connection handler failed
Traceback (most recent call last):
  File "libdatachannel/examples/signaling-server-python/venv/lib/python3.10/site-packages/websockets/asyncio/server.py", line 374, in conn_handler
    await self.handler(connection)
TypeError: handle_websocket() missing 1 required positional argument: 'path'

Using the legacy serve() does seem to resolve the issue for the moment.

[SirNate0]

The new version stores the URL path in the request attribute of the websocket ServerConnection. Specifically as ws.request.path where ws is the ServerConnection argument passed to the handler function when the websocket is opened.

[Nemirtingas]

Hi, I confirm this, I've re-installed my test server 2 days ago and just installed the old websockets 12.