Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would notification drawer benefit from a general empty state? #528

Open
benjaminapetersen opened this issue Jul 26, 2017 · 1 comment
Open

Comments

@benjaminapetersen
Copy link
Member

benjaminapetersen commented Jul 26, 2017

Related to #526

original comment

The individual empty tab messages are a big improvement. Its possible that a user could still be a bit frustrated opening each tab only to find that there are no notifications. It may be beneficial to provide a generalized way to indicate to the user that there are no new notifications at all.

screen shot 2017-07-26 at 10 19 48 am

That may be able to be solved programmatically by updating the notifications-body.html with something like:

<div ng-if="!totalNotificationCount">
   <!-- show a message if there zero notifications -->
</div>
<div ng-if="totalNotificationCount">
   <!-- show the current body -->
</div>

If this is acceptable, then I would simply propose an update to the docs.

Another possibility might be to provide a new attrib for an empty state template:

notification-body-include="notification-body.html"
notification-body-empty-include="notification-body-empty.html"

At first glance this seems like it would be nice as it abstracts away some of the noise, but I'm not sure if its worth the cost of $watch-ing notification-groups to count all of the notifications in each array in order to trigger the template change.

@jeff-phillips-18

@beanh66
Copy link
Member

beanh66 commented Nov 14, 2017

In OpenShift, the accordion is not used so this issue does not apply. Changing to priority 3 for now. Will bring back up if other products experience this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants