Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The behavior of Jade can make complicated integration #48

Closed
pmaoui opened this issue Mar 5, 2016 · 1 comment
Closed

The behavior of Jade can make complicated integration #48

pmaoui opened this issue Mar 5, 2016 · 1 comment

Comments

@pmaoui
Copy link

pmaoui commented Mar 5, 2016

Hi, thank you for this module.

I had to investigate to understand why this module doesn't worked "out of the box" just by adding data-fittext as a directive on my element.

It appears that Jade compiles data-fittext as data-fittext="data-fittext" in HTML in order to support older browser (they don't like empty attribute). I would suggest to use a specific attribute name for the compressor value instead of using the default directive attribute value.

It's not a big deal but Jade is quite popular and it will probably save some time to other people in the exact same situation :)

Regards,

@patrickmarabeas
Copy link
Owner

Duplicate of #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants