Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename config value provider #26

Closed
dubejf opened this issue May 31, 2015 · 1 comment
Closed

Rename config value provider #26

dubejf opened this issue May 31, 2015 · 1 comment

Comments

@dubejf
Copy link

dubejf commented May 31, 2015

The config value provider conflicts with a service of the same name in my application.

The config provider should be prefixed. I would suggest fitTextConstants or fitTextDefaultConfig would be better names.
@patrickmarabeas
Copy link
Owner

Thanks for heads up. This will be rolled out in v4.x

(sorry for delay!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@patrickmarabeas @dubejf