Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't depend on whole of bower #27

Open
sindresorhus opened this issue May 15, 2015 · 3 comments
Open

Don't depend on whole of bower #27

sindresorhus opened this issue May 15, 2015 · 3 comments

Comments

@sindresorhus
Copy link
Contributor

The dependency is absolutely massive. Currently this module with dependencies takes up 54 MB!

Instead just spawn the global bower CLI.

Related to btford/grunt-google-cdn#62

@passy
Copy link
Owner

passy commented May 21, 2015

While the reasoning behind is obviously correct I really dislike the ugly work-around needed to solve a problem npm should solve for us. Especially because this brings all sorts of nasty problems with it. What if bower is not on the PATH we run this in? How do we verify that the version is compatible? How do we handle all the OS-specific errors spawning the process and piping the output brings with it?

@sindresorhus
Copy link
Contributor Author

You're only using Bower to get the main entry, so you could just use https://github.com/bower/json directly.

@passy
Copy link
Owner

passy commented May 21, 2015

Yeah, with that I'd be totally cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants