Skip to content

[BUG] Passport developers should be able to verify stamps with the approapiate sync option through our SDK #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
erichfi opened this issue Sep 15, 2022 · 3 comments · May be fixed by passportxyz/passport-sdk#20
Closed

[BUG] Passport developers should be able to verify stamps with the approapiate sync option through our SDK #594

erichfi opened this issue Sep 15, 2022 · 3 comments · May be fixed by passportxyz/passport-sdk#20
Assignees
@nutrina

Comments

@erichfi
Copy link
Contributor

erichfi commented Sep 15, 2022 •
edited
Loading

Scenario

  • Developer wants to verify stamps with SDK verifier
  • Developer inputs VC in SDK verifier

Expected result

  • SDK verifier gives positive returns for legitimate VCs

Actual result

  • SDK verifier shows the verified status as "false" for legit credential

Notes

  • This is an error in our sync option -> the same one we have fixed for passport and the TB page
@nutrina nutrina moved this from Backlog to In Progress (WIP) in Passport Sep 15, 2022
@nutrina nutrina self-assigned this Sep 15, 2022
@nutrina nutrina mentioned this issue Sep 15, 2022
Open
@nutrina
Copy link
Collaborator

nutrina commented Sep 16, 2022

The SDK verifier is ok, the examples where out of date. A PR exists for that.
However only the NextJS version is functional.
The other one is not loading the wasm library from Spruce, loading async web assembly is not yet enabled.

Will need to look into that.

@nutrina nutrina moved this from In Progress (WIP) to Needs Review in Passport Sep 19, 2022
@nutrina nutrina moved this from Needs Review to In Progress (WIP) in Passport Oct 21, 2022
@nutrina
Copy link
Collaborator

nutrina commented Oct 21, 2022

Need to double-check the PR, get it approved and merged and close this ticket.

@nutrina nutrina moved this from In Progress (WIP) to Backlog in Passport Nov 17, 2022
@nutrina nutrina moved this from Backlog to In Progress (WIP) in Passport Nov 17, 2022
@nutrina
Copy link
Collaborator

nutrina commented Nov 17, 2022

Waiting for approvals on the PR: passportxyz/passport-sdk#20

@nutrina nutrina moved this from In Progress (WIP) to Needs Review in Passport Nov 17, 2022
@erichfi erichfi moved this from Needs Review to Accepted in Passport Nov 30, 2022
@erichfi erichfi moved this from Ready to Deploy to Done in Passport Jan 23, 2023
@erichfi erichfi closed this as completed Jan 23, 2023
@github-project-automation github-project-automation bot moved this from Done to Ready to Deploy in Passport Jan 23, 2023
@erichfi erichfi moved this from Ready to Deploy to Done in Passport Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nutrina nutrina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix verifier package version used in verifier examples passportxyz/passport-sdk
2 participants
@nutrina @erichfi