Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access token should be CLI specific, and not cause web IDE to be logged out. #7

Closed
dmiddlecamp opened this issue Feb 25, 2014 · 8 comments
Labels

Comments

@dmiddlecamp
Copy link
Contributor

Getting reports that logging into the CLI knocked out the build IDE access_token.

@dmiddlecamp
Copy link
Contributor Author

Working on this now.

@dmiddlecamp
Copy link
Contributor Author

API Docs says "For now, Spark Build will list the single most recently created token." ( http://docs.spark.io/#/api/authentication-generate-a-new-access-token ), but shouldn't invalidate the previous token... I tested this, and my previously generated token continued to work.

@dmiddlecamp
Copy link
Contributor Author

Nope, just kidding. If you use a token generated by the build site, and then create a new oauth token, the build site token is invalidated.

@kennethlimcp
Copy link
Contributor

@dmiddlecamp So the access_token for Sparkbuild (client spark) is not listed under my access tokens but i can still do API calls and read my variables.

Only the access_tokens for client spark-cli was seen.

@towynlin
Copy link
Contributor

Thanks @kennethlimcp, yeah, the access token shown in the web IDE is a transitional one from before we had multiple access tokens. My understanding is that if you see one listed for spark-cli, that if you go refresh the build site now, the token shown should match the cli token. Let us know if that's not the case. Between @dmiddlecamp and me, we have planned a set of changes that should migrate everyone smoothly forward whether using Spark Build, the mobile apps, or the CLI.

@kennethlimcp
Copy link
Contributor

@towynlin oh yes indeed i noticed that. Luckily this was noticed fast and the usage of CLI isn't that high as of now 👯

@kennethlimcp
Copy link
Contributor

@towynlin and @dmiddlecamp I have got this tested and working. good job!

Time to close this? :)

@towynlin
Copy link
Contributor

Yup, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants