Spark.cli ignore spark.ignore

[Ryotsuke]

http://screenshots.ryotsuke.ru/scr_ccbec1ed89fc.png
Screenshot pretty explains it

[dmiddlecamp]

It looks like you're pushing from the directory below, instead of the directory with the spark.ignore file?

[Ryotsuke]

That's not an issue.
Issue starts when I have more than 1 line in this file
Perhaps because on Windows

[Ryotsuke]

Besides I should push from ./ if code and ignore file is in ./ApplicationDir

[dmiddlecamp]

Hi @Ryotsuke ,

What I mean is that if you tell the CLI to compile a directory, it looks there for the ignore file, so it depends where the file is located / where you're running it from. I'll still look into it though. :)

Hmm... it's possible it's a "\n" vs. "\r\n" thing...

[dmiddlecamp]

Hi @Ryotsuke,

Can you confirm if this is still an issue, or can you provide the build command you're running to help me confirm the problem? Since this bug was posted I've added extra trimming logic when parsing include/ignore files, which might have solved the potential windows newline issue.

Thanks!
David

[dmiddlecamp]

This should be fixed with new glob behavior in 0.4.6