Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace angular2-qrcode #800

Closed
kewde opened this issue Feb 6, 2018 · 5 comments
Closed

Replace angular2-qrcode #800

kewde opened this issue Feb 6, 2018 · 5 comments

Comments

@kewde
Copy link
Collaborator

kewde commented Feb 6, 2018

It uses some native dependencies for some odd reason 'canvas', it's an optional dependency but it fails to build and has caused issue with electron-builder builds in the past, need to get rid of it.
Replace it with something more robust.

@vikas-cis-zz
Copy link

@kewde
Can we try the below and use one of them if it make sense ?

https://www.npmjs.com/package/ng2-qrcode
https://www.npmjs.com/package/angular2-qrcode-generator

Thanks

@kewde
Copy link
Collaborator Author

kewde commented Feb 7, 2018

https://www.npmjs.com/package/ng2-qrcode

That one looks fine to me.
Make sure to remove all the existing angular2-qrcode stuff, import the QrCodeModule in the CoreUiModule.

@vikas-cis-zz
Copy link

@kewde thanks will check and do a pr

@vikas-cis-zz
Copy link

vikas-cis-zz commented Feb 7, 2018

@kewde I think we cannot use that
PragmaticClub/ng2-qrcode#12

Edited: In place of that https://github.com/Cordobo/angularx-qrcode let me know if that make sense ?

Thanks

@kewde
Copy link
Collaborator Author

kewde commented Feb 7, 2018

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants