Construct staged integrators via arbitrary name #975
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This MR alters the
LowStorageIntegrator
andButcherIntegrator
constructors such that they are capable of taking an arbitrary string. Previously, both constructors took as argument aParameterInput *pin
parameter and assigned an integrator namepin->GetOrAddString("parthenon/time", "integrator", "rk2")
. This inhibited a downstream user from producing two unique instances of aStagedIntegrator
that did not share the same stringed name. I attempted to ensure backwards compatibility of instantiating integrators viaParameterInput *pin
; I did this by supporting an additional constructor (taking as argumentParameterInput *pin
) that calls my newly added constructor (taking as argumentstd::string &name
).PR Checklist