-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GetPackDimension
to StateDescriptor
#1148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes when initializing a package, you want to know how many variables another package has declared (e.g., a `Flux` package might need the total number of `WithFluxes` variables declared so far). The `Mesh` doesn't exist yet, so you have to ask the other packages directly what they've declared. Thus, `GetPackDimension`.
bprather
changed the title
WIP: Add
Add Aug 5, 2024
GetPackDimension
to StateDescriptor
GetPackDimension
to StateDescriptor
pgrete
reviewed
Aug 8, 2024
Yurlungur
approved these changes
Aug 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments below.
pgrete
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when initializing a package, you want to know how many variables another package has declared (e.g., a
Flux
package might need the total number ofWithFluxes
variables declared so far). TheMesh
doesn't exist yet, so you have to ask the other packages directly, and have them tally up variable lists. Thus,GetPackDimension
.This is the last of the patches I've been carrying in KHARMA's version of Parthenon vs.
develop
. It works for my purposes downstream,but I'm pretty sure it would fail forOverridable
variables and maybe other corner cases. Happy to try to make it more robust if it seems useful, or keep it downstream if no one else needs this kind of info at package init time (or maybe there's some cleaner way to get it? Create a temporaryresolved_state
or something?)I've checked and these functions work fine for the
StateDescriptor
returned byCreateResolvedStateDescriptor
, which I think already resolves anyOverridable
variables down to a single entry each. So, if anyone else needs this sort of crazy thing, the code in here at least has a decent chance of being robust for whatever use case they're throwing at it. Since I think the overall function has a chance of being broadly useful, I'm going to remove WIP, add a changelog entry, and ask for reviews/opinions.PR Checklist