Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing include guard for hdf5 restart #1095

Merged
merged 3 commits into from
Jun 5, 2024
Merged

add missing include guard for hdf5 restart #1095

merged 3 commits into from
Jun 5, 2024

Conversation

Yurlungur
Copy link
Collaborator

PR Summary

This adds the missing preprocessor macro that should let us build with disabled HDF5. Resolves #1094

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@Yurlungur Yurlungur added bug Something isn't working io Fix labels May 30, 2024
@Yurlungur Yurlungur self-assigned this May 30, 2024
@Yurlungur Yurlungur mentioned this pull request May 30, 2024
Closed
pdmullen
pdmullen approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@pdmullen pdmullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yurlungur Yurlungur enabled auto-merge June 5, 2024 12:51
pgrete
pgrete approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@pgrete pgrete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Missed those when refactoring restarts.

Thanks!

@Yurlungur Yurlungur disabled auto-merge June 5, 2024 14:10
@Yurlungur Yurlungur enabled auto-merge June 5, 2024 14:10
lroberts36
lroberts36 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@lroberts36 lroberts36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yurlungur Yurlungur merged commit ebd3e69 into develop Jun 5, 2024
50 of 54 checks passed
@fglines-nv
Copy link
Collaborator

A bit late to the party, but can confirm, this fixed the build issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdmullen pdmullen pdmullen approved these changes

@pgrete pgrete pgrete approved these changes

@lroberts36 lroberts36 lroberts36 approved these changes

@forrestglines forrestglines Awaiting requested review from forrestglines

Assignees

@Yurlungur Yurlungur

Labels
bug Something isn't working Fix io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken disabled HDF5 builds
6 participants
@Yurlungur @fglines-nv @lroberts36 @pgrete @pdmullen @jonahm-LANL