-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the correct root level on restart #1053
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, this explains some of the issues I've been seeing.
With current develop I got
Number of physical refinement levels = 2
Number of logical refinement levels = 4
for a sample restart from the input file of the advection example.
With this branch I get the
Number of physical refinement levels = 2
Number of logical refinement levels = 2
that matches the original run.
So just double checking: The GetLegacyRootLevel
call for the output is correct, isn't it?
Also what worries me is that we didn't catch this with the regression tests (particularly as current develop segfaults on restart with the advection example...). |
@pgrete: I am a little surprised |
PR Summary
Currently, on restart
Mesh::root_level
andMesh::current_level
get set to levels relative to the legacy tree, which is incorrect (see issue #1051). This PR fixes the issue.PR Checklist