Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "physics-based" reconstruction #35

Open
BenWibking opened this issue Mar 11, 2023 · 2 comments
Open

Adding "physics-based" reconstruction #35

BenWibking opened this issue Mar 11, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@BenWibking
Copy link
Contributor

For various things, it would be useful to reconstruct a different set of variables other than the primitive variables. For example, we might want to reconstruct (density, velocity, temperature) instead, or we might we to reconstruct using the characteristic waves.

How can this best be accomplished with the current machinery? Can we do this cell-by-cell, e.g., with an inline function within the reconstruction kernel?

@BenWibking BenWibking added the enhancement New feature or request label Mar 11, 2023
@pgrete
Copy link
Contributor

pgrete commented Mar 13, 2023

Short answer: yes, that should be possible

Depending on many different variations this will get, it'd make either sense to extend the current calculate flux function to do some conversion before calling the reconstruction functions or duplicate the calculate flux kernel if a lot more logic would be required).
The conversion should be straightforward, once the individual cell based inline conversion functions that @forrestglines implemented in the cluster branch are in place.

@BenWibking
Copy link
Contributor Author

Reconstructing in temperature instead of pressure is necessary for my current simulation project. Will follow up to see if we can discuss this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants