Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of NGLMMHD (and similar) vars #25

Open
pgrete opened this issue Feb 14, 2023 · 0 comments
Open

Cleanup of NGLMMHD (and similar) vars #25

pgrete opened this issue Feb 14, 2023 · 0 comments
Labels
refactor

Comments

@pgrete
Copy link
Contributor

pgrete commented Feb 14, 2023

From https://gitlab.com/theias/hpc/jmstone/athena-parthenon/athenapk/-/issues/2:
The use is not consistent (sometimes constexpr, sometimes GetDim from parameter pack, sometimes duplicate hardcoded in specific function, e.g., pgen for hydro and mhd linear wave).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pgrete