-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"schemaCacheTTL" ParseServerOption is not working #7119
Comments
@dplewis I actually don't see the schemaCacheTTL being used here: https://github.com/parse-community/parse-server/blob/e6ac3b6932186a6a85601c65143305f86f63e948/src/Controllers/SchemaCache.js Thoughts? |
Check the constructor |
Hi @davimacedo @dplewis , is there any update? The schemaCacheTTL was set to ttl at the constructor, but it doesn't pass to the cacheController at Line 33. I'm not sure is it the main problem here. |
The constructor uses only the default value but not a value eventually passed via parse server options, right? |
Should be passed here Line 31 in e6ac3b6
|
@jack092123 would you mind to write a failing test case? |
Hi @davimacedo, this is my first time reporting issue & writing a test script. So feel free to correct me if there is a mistake. I add a failing test case to my forked repo here. So what should I do next? Summit a pull request? |
Yes. You can open a PR with the test. Are you willed to also investigate and try to send a fix? |
🎉 This change has been released in version 5.0.0-beta.1 |
🎉 This change has been released in version 5.0.0 |
New Issue Checklist
Issue Description
It seems
schemaCacheTTL
ParseServerOption is not working. It still follows cacheAdapter's setting.Steps to reproduce
ParseOption
enableSingleSchemaCache
: true,schemaCacheTTL
: 3600000, (1hr)cacheAdapter
: RedisCacheAdapterActual Outcome
After a simple request, I check the keys in Redis. The schema cache's TTL is 30 seconds which is the RedisCacheAdapter's default TTL.
Environment
Server
4.3.0
MacOS
Local
Database
MongoDB
3.6
Local
I'm not quite sure, but I think the problem might be here. It doesn't pass the TTL config to the cache.
The text was updated successfully, but these errors were encountered: