Parse-maintained node-apn

[Vortec4800]

Is Parse maintaining their own fork of node-apn now? I'm getting a ton of errors when sending push messages about HTTP2 GOAWAY handling that seem to be related to this issue/PR: node-apn/node-apn#640

That's from quite a while ago now and it seems like it's not going to be merged in, and even if it is I don't know if it would get merged in the new Parse fork.

[funkenstrahlen]

Parse does maintain its own fork of node-apn for some weeks now. Exactly for this reason: We want to be able to change code without relying on an inactive node-apn repository.

As far as I can see this issue could be fixed if we merge this into our fork: node-apn/node-apn#643

Correct?

[funkenstrahlen]

If everyone agrees on this I can apply the changes to our fork tomorrow.

[funkenstrahlen]

@Vortec4800 In case you have some time to work on it you could also create the PR to our fork: https://github.com/parse-community/node-apn

[Vortec4800]

That is my (admittedly limited) understanding as well. I might be able to do it later today, if so I'll put together a PR.

[funkenstrahlen]

I found some time this morning and created a PR with the required changes: parse-community/node-apn#7

[Vortec4800]

Cool thanks for this, will be good to get this merged and updated when it's ready.

[davimacedo]

closed via parse-community/node-apn#7