Merge pull request #66 from gmile/remove-dicts

Clean up Dict usage

Author: parroty

lib/exvcr/task/runner.ex

@@ -90,18 +90,18 @@ defmodule ExVCR.Task.Runner do
   defp create_count_hash([], acc), do: acc
   defp create_count_hash([{type, path}|tail], acc) do
     file = Path.basename(path)
-    counts = Dict.get(acc, file, %ExVCR.Checker.Counts{})
+    counts = Map.get(acc, file, %ExVCR.Checker.Counts{})
     hash = case type do
-      :cache  -> Dict.put(acc, file, %{counts | cache: counts.cache + 1})
-      :server -> Dict.put(acc, file, %{counts | server: counts.server + 1})
+      :cache  -> Map.put(acc, file, %{counts | cache: counts.cache + 1})
+      :server -> Map.put(acc, file, %{counts | server: counts.server + 1})
     end
     create_count_hash(tail, hash)
   end
 
   defp print_check_cassettes(items, counts_hash) do
     printf(@check_header_format, ["[File Name]", "[Cassette Counts]", "[Server Counts]"])
     Enum.each(items, fn({name, _date}) ->
-      counts = Dict.get(counts_hash, name, %ExVCR.Checker.Counts{})
+      counts = Map.get(counts_hash, name, %ExVCR.Checker.Counts{})
       printf(@check_content_format, [name, counts.cache, counts.server])
     end)
   end

lib/exvcr/task/show.ex

@@ -34,17 +34,10 @@ defmodule ExVCR.Task.Show do
   end
 
   defp extract_body(json) do
-    response = JSX.decode!(json)
-               |> List.first
-               |> Enum.into(HashDict.new)
-               |> fetch_value("response")
-    Enum.into(response, HashDict.new) |> fetch_value("body")
-  end
-
-  defp fetch_value(dict, key) do
-    case HashDict.fetch(dict, key) do
-      {:ok, value} -> value
-      _ -> []
-    end
+    json
+    |> JSX.decode!()
+    |> List.first()
+    |> Enum.into(%{})
+    |> get_in(["responce", "body"])
   end
 end