Skip to content
This repository has been archived by the owner on Feb 19, 2023. It is now read-only.

Co-authors #40

Open
pathawks opened this issue Jul 11, 2018 · 3 comments
Open

Co-authors #40

pathawks opened this issue Jul 11, 2018 · 3 comments

Comments

@pathawks
Copy link
Contributor

If a PR has commits from multiple authors, it would be cool if @jekyllbot could include them all as Co-authors when squash-merging the PR.

Perhaps whoever created the initial PR (or maybe opened the PR) would be the primary author and others would be co-authors? We like collaboration, and want to encourage working together to get PRs ready to merge. Proper attribution seems only fair.

@ashmaroli
Copy link

I think its more of a Git limitation than JekyllBot's. The result would be the same if the commits were squashed manually on the terminal.

What JekyllBot could do is intelligently add the Co-authored-by: attribute to the final merge commit, if applicable (only if one of the individual commits have the said Co-authored-by: attribute.)

@pathawks
Copy link
Contributor Author

@ashmaroli Yes, we would have to do some manual work rather than relying on Git, but we are already setting the commit message manually, so this would be no different in principle.

It's not just the case where a PR contains commits that include Co-authored-by; there have been cases where you push commits to one of my PRs or I push commits to one of your PRs. If a PR has commits from multiple authors, it seems that all should get credit.

@ashmaroli
Copy link

Fair point 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants