Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate diffs with one line of context #49

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

parkerbxyz
Copy link
Owner

@parkerbxyz parkerbxyz commented Oct 10, 2024

When diffs are generated with zero lines of context (git diff --unified=0), review comments with suggested changes will sometimes suggest deleting a line that shouldn't be deleted.

@parkerbxyz parkerbxyz self-assigned this Oct 10, 2024
@parkerbxyz parkerbxyz marked this pull request as ready for review October 10, 2024 21:43
@parkerbxyz parkerbxyz merged commit 994b05c into main Oct 10, 2024
@parkerbxyz parkerbxyz deleted the fix-added-line-delete-bug branch October 10, 2024 21:43
@parkerbxyz parkerbxyz linked an issue Oct 11, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Pull request review thread line must be part of the diff
1 participant