diff --git a/polkadot/runtime/src/utils.rs b/polkadot/runtime/src/utils.rs index 4c16e215bab7e..1531590ff5fca 100644 --- a/polkadot/runtime/src/utils.rs +++ b/polkadot/runtime/src/utils.rs @@ -47,5 +47,5 @@ pub fn inherent_extrinsics(timestamp: ::primitives::Timestamp, parachain_heads: /// Checks an unchecked extrinsic for validity. pub fn check_extrinsic(xt: UncheckedExtrinsic) -> bool { - xt.check(Staking::lookup).is_ok() + xt.check_with(Staking::lookup).is_ok() } diff --git a/polkadot/transaction-pool/src/lib.rs b/polkadot/transaction-pool/src/lib.rs index 5f344035cec0a..85b06698b0179 100644 --- a/polkadot/transaction-pool/src/lib.rs +++ b/polkadot/transaction-pool/src/lib.rs @@ -55,7 +55,7 @@ pub use extrinsic_pool::txpool::{Options, Status, LightStatus, VerifiedTransacti pub use error::{Error, ErrorKind, Result}; /// Type alias for convenience. -pub type CheckedExtrinsic = ::Checked; +pub type CheckedExtrinsic = std::result::Result>>::Checked; /// A verified transaction which should be includable and non-inherent. #[derive(Clone, Debug)] @@ -281,7 +281,7 @@ impl<'a, A> txpool::Verifier for Verifier<'a, A> where } let (encoded_size, hash) = uxt.using_encoded(|e| (e.len(), BlakeTwo256::hash(e))); - let inner = match uxt.clone().check(|a| self.lookup(a)) { + let inner = match uxt.clone().check_with(|a| self.lookup(a)) { Ok(xt) => Some(xt), // keep the transaction around in the future pool and attempt to promote it later. Err(Self::NO_ACCOUNT) => None, diff --git a/substrate/runtime/council/src/lib.rs b/substrate/runtime/council/src/lib.rs index a40a64b27b84f..e6c3c9b4164d4 100644 --- a/substrate/runtime/council/src/lib.rs +++ b/substrate/runtime/council/src/lib.rs @@ -549,7 +549,7 @@ impl Module { #[serde(rename_all = "camelCase")] #[serde(deny_unknown_fields)] pub struct GenesisConfig { - // for the voting onto the council + // for the voting onto the council pub candidacy_bond: T::Balance, pub voter_bond: T::Balance, pub present_slash_per_voter: T::Balance, diff --git a/substrate/runtime/executive/src/lib.rs b/substrate/runtime/executive/src/lib.rs index e5a8a1a19e29a..fd4e9a0c0e3a7 100644 --- a/substrate/runtime/executive/src/lib.rs +++ b/substrate/runtime/executive/src/lib.rs @@ -82,14 +82,15 @@ pub struct Executive< >(PhantomData<(System, Block, Lookup, Payment, Finalisation)>); impl< + Address, System: system::Trait, Block: traits::Block, - Lookup: AuxLookup::Address, Target=System::AccountId>, + Lookup: AuxLookup, Payment: MakePayment, Finalisation: Executable, > Executive where - Block::Extrinsic: Checkable + Slicable, - ::Checked: Applyable + Block::Extrinsic: Checkable Result> + Slicable, + Result>>::Checked: Applyable { /// Start the execution of a particular block. pub fn initialise_block(header: &System::Header) { @@ -172,7 +173,7 @@ impl< /// Actually apply an extrinsic given its `encoded_len`; this doesn't note its hash. fn apply_extrinsic_no_note_with_len(uxt: Block::Extrinsic, encoded_len: usize) -> result::Result { // Verify the signature is good. - let xt = uxt.check(Lookup::lookup).map_err(internal::ApplyError::BadSignature)?; + let xt = uxt.check_with(Lookup::lookup).map_err(internal::ApplyError::BadSignature)?; if xt.sender() != &Default::default() { // check index diff --git a/substrate/runtime/primitives/src/generic.rs b/substrate/runtime/primitives/src/generic.rs index 6f8a46841c748..0c50b2d8f7b01 100644 --- a/substrate/runtime/primitives/src/generic.rs +++ b/substrate/runtime/primitives/src/generic.rs @@ -96,7 +96,7 @@ impl UncheckedExtrinsic traits::Checkable +impl traits::Checkable for UncheckedExtrinsic> where Address: Member + Default + MaybeDisplay, @@ -106,18 +106,11 @@ where AccountId: Member + Default + MaybeDisplay, ::MaybeUnsigned: Member, Extrinsic: Slicable, + ThisLookup: FnOnce(Address) -> Result, { - type Address = Address; - type AccountId = AccountId; type Checked = CheckedExtrinsic; - fn sender(&self) -> &Address { - &self.extrinsic.signed - } - - fn check(self, lookup: ThisLookup) -> Result where - ThisLookup: FnOnce(Address) -> Result, - { + fn check_with(self, lookup: ThisLookup) -> Result { if !self.is_signed() { Ok(CheckedExtrinsic(Extrinsic { signed: Default::default(), diff --git a/substrate/runtime/primitives/src/testing.rs b/substrate/runtime/primitives/src/testing.rs index 7c712b40105e6..12e347e1e3a8b 100644 --- a/substrate/runtime/primitives/src/testing.rs +++ b/substrate/runtime/primitives/src/testing.rs @@ -157,12 +157,9 @@ impl Checkable for TestXt { +impl Checkable for TestXt { type Checked = Self; - type Address = u64; - type AccountId = u64; - fn sender(&self) -> &u64 { &(self.0).0 } - fn check Result>(self, _lookup: ThisLookup) -> Result { Ok(self) } + fn check_with(self, _: Context) -> Result { Ok(self) } } impl + Slicable + Sized + Send + Sync + Serialize + DeserializeOwned + Clone + Eq + Debug> Applyable for TestXt { type AccountId = u64; diff --git a/substrate/runtime/primitives/src/traits.rs b/substrate/runtime/primitives/src/traits.rs index 218fbc12769f6..aafbcc56be57a 100644 --- a/substrate/runtime/primitives/src/traits.rs +++ b/substrate/runtime/primitives/src/traits.rs @@ -371,31 +371,32 @@ pub type HashingFor = <::Header as Header>::Hashing; /// A "checkable" piece of information, used by the standard Substrate Executive in order to /// check the validity of a piece of extrinsic information, usually by verifying the signature. -pub trait Checkable: Sized + Send + Sync { - type Address: Member + MaybeDisplay; - type AccountId: Member + MaybeDisplay; - type Checked: Member; - fn sender(&self) -> &Self::Address; - fn check Result>(self, lookup: ThisLookup) -> Result; +/// Implement for pieces of information that require some additional context `Context` in order to be +/// checked. +pub trait Checkable: Sized { + /// Returned if `check_with` succeeds. + type Checked; + + fn check_with(self, context: Context) -> Result; } /// A "checkable" piece of information, used by the standard Substrate Executive in order to /// check the validity of a piece of extrinsic information, usually by verifying the signature. -/// -/// This does that checking without requiring a lookup argument. -pub trait BlindCheckable: Sized + Send + Sync { - type Address: Member + MaybeDisplay; - type Checked: Member; - fn sender(&self) -> &Self::Address; +/// Implement for pieces of information that don't require additional context in order to be +/// checked. +pub trait BlindCheckable: Sized { + /// Returned if `check` succeeds. + type Checked; + fn check(self) -> Result; } -impl Checkable for T { - type Address = ::Address; - type AccountId = ::Address; +// Every `BlindCheckable` is also a `Checkable` for arbitrary `Context`. +impl Checkable for T { type Checked = ::Checked; - fn sender(&self) -> &Self::Address { BlindCheckable::sender(self) } - fn check Result>(self, _: ThisLookup) -> Result { BlindCheckable::check(self) } + fn check_with(self, _: Context) -> Result { + BlindCheckable::check(self) + } } /// An "executable" piece of information, used by the standard Substrate Executive in order to diff --git a/substrate/test-runtime/src/lib.rs b/substrate/test-runtime/src/lib.rs index 1b07035e966e8..ee4357aaeee76 100644 --- a/substrate/test-runtime/src/lib.rs +++ b/substrate/test-runtime/src/lib.rs @@ -119,11 +119,7 @@ impl Slicable for Extrinsic { impl BlindCheckable for Extrinsic { type Checked = Self; - type Address = AccountId; - fn sender(&self) -> &Self::Address { - &self.transfer.from - } fn check(self) -> Result { if ::runtime_primitives::verify_encoded_lazy(&self.signature, &self.transfer, &self.transfer.from) { Ok(self)