Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

contracts: Revise seal_call #8421

Closed
cmichi opened this issue Mar 22, 2021 · 0 comments · Fixed by #8909
Closed

contracts: Revise seal_call #8421

cmichi opened this issue Mar 22, 2021 · 0 comments · Fixed by #8909
Labels
J0-enhancement An additional feature request. Z3-substantial Can be fixed by an experienced coder with a working knowledge of the codebase.

Comments

@cmichi
Copy link
Contributor

cmichi commented Mar 22, 2021

Copy-Pasting from use-ink/ink#739, which is blocked by this.

We would need to add a new version of seal_call though. I can imagine a new seal_call that adds a flag parameter for future extensibility. The initially supported flags could be:

FORWARD_INPUT - Forward the input of current functions to the callee. Panics if input was already read.
TAILCALL - Do not return from the call but rather return the result of the callee to the callers caller.
DENY_REENTRANCY - Panic if the callee (the contract) is already on the call stack.
@cmichi cmichi added the J0-enhancement An additional feature request. label Mar 22, 2021
@athei athei added U3-nice_to_have Issue is worth doing eventually. Z3-substantial Can be fixed by an experienced coder with a working knowledge of the codebase. U2-some_time_soon Issue is worth doing soon. and removed U3-nice_to_have Issue is worth doing eventually. U2-some_time_soon Issue is worth doing soon. labels Mar 22, 2021
@athei athei mentioned this issue May 26, 2021
Merged
@ghost ghost closed this as completed in #8909 Jun 7, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
J0-enhancement An additional feature request. Z3-substantial Can be fixed by an experienced coder with a working knowledge of the codebase.
Projects
Smart Contracts
Status: Done ✅
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

contracts: Add new seal_call that offers new features paritytech/substrate
2 participants
@cmichi @athei