Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Take into account proof size for transaction payment and priority #13898

Closed
kianenigma opened this issue Apr 13, 2023 · 0 comments · Fixed by #13958
Closed

Take into account proof size for transaction payment and priority #13898

kianenigma opened this issue Apr 13, 2023 · 0 comments · Fixed by #13958
Assignees
Labels
J0-enhancement An additional feature request. T1-runtime This PR/Issue is related to the topic “runtime”.

Comments

@kianenigma
Copy link
Contributor

See:

// TODO: Take into account all dimensions of weight
let max_block_weight = max_block_weight.ref_time();
let info_weight = info.weight.ref_time();

and

// TODO: Handle all weight dimensions
let normal_max_weight = normal_max_weight.ref_time();
let normal_block_weight = normal_block_weight.ref_time();

In both cases, a .max should be a safe and sane approach.

@kianenigma kianenigma added the U2-some_time_soon Issue is worth doing soon. label Apr 13, 2023
@juangirini juangirini added J0-enhancement An additional feature request. and removed U2-some_time_soon Issue is worth doing soon. labels May 22, 2023
@juangirini juangirini added the T1-runtime This PR/Issue is related to the topic “runtime”. label Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants