Don’t try to send a body with a GET request

without adding a Transfer-Encoding or Content-Length header.

This has always been wrong, but hyperium/hyper#1925 hid the bug until
hyper was upgraded to 0.12.35.

Author: Demi-Marie

core/offchain/src/api/http.rs

@@ -848,7 +848,7 @@ mod tests {
 			_ => panic!()
 		};
 
-		let id = api.request_start("GET", &format!("http://{}", addr)).unwrap();
+		let id = api.request_start("POST", &format!("http://{}", addr)).unwrap();
 		api.request_write_body(id, &[1, 2, 3, 4], None).unwrap();
 		api.request_write_body(id, &[1, 2, 3, 4], None).unwrap();
 		api.request_write_body(id, &[], None).unwrap();
@@ -857,7 +857,7 @@ mod tests {
 			_ => panic!()
 		};
 
-		let id = api.request_start("GET", &format!("http://{}", addr)).unwrap();
+		let id = api.request_start("POST", &format!("http://{}", addr)).unwrap();
 		api.request_write_body(id, &[1, 2, 3, 4], None).unwrap();
 		api.request_write_body(id, &[1, 2, 3, 4], None).unwrap();
 		api.request_write_body(id, &[], None).unwrap();
@@ -866,44 +866,44 @@ mod tests {
 			_ => panic!()
 		};
 
-		let id = api.request_start("GET", &format!("http://{}", addr)).unwrap();
+		let id = api.request_start("POST", &format!("http://{}", addr)).unwrap();
 		api.request_write_body(id, &[1, 2, 3, 4], None).unwrap();
 		api.response_wait(&[id], None);
 		match api.request_write_body(id, &[], None) {
 			Err(HttpError::Invalid) => {}
 			_ => panic!()
 		};
 
-		let id = api.request_start("GET", &format!("http://{}", addr)).unwrap();
+		let id = api.request_start("POST", &format!("http://{}", addr)).unwrap();
 		api.request_write_body(id, &[1, 2, 3, 4], None).unwrap();
 		api.response_wait(&[id], None);
 		match api.request_write_body(id, &[1, 2, 3, 4], None) {
 			Err(HttpError::Invalid) => {}
 			_ => panic!()
 		};
 
-		let id = api.request_start("GET", &format!("http://{}", addr)).unwrap();
+		let id = api.request_start("POST", &format!("http://{}", addr)).unwrap();
 		api.response_headers(id);
 		match api.request_write_body(id, &[1, 2, 3, 4], None) {
 			Err(HttpError::Invalid) => {}
 			_ => panic!()
 		};
 
-		let id = api.request_start("GET", &format!("http://{}", addr)).unwrap();
+		let id = api.request_start("POST", &format!("http://{}", addr)).unwrap();
 		api.response_headers(id);
 		match api.request_write_body(id, &[], None) {
 			Err(HttpError::Invalid) => {}
 			_ => panic!()
 		};
 
-		let id = api.request_start("GET", &format!("http://{}", addr)).unwrap();
+		let id = api.request_start("POST", &format!("http://{}", addr)).unwrap();
 		api.response_read_body(id, &mut [], None).unwrap();
 		match api.request_write_body(id, &[1, 2, 3, 4], None) {
 			Err(HttpError::Invalid) => {}
 			_ => panic!()
 		};
 
-		let id = api.request_start("GET", &format!("http://{}", addr)).unwrap();
+		let id = api.request_start("POST", &format!("http://{}", addr)).unwrap();
 		api.response_read_body(id, &mut [], None).unwrap();
 		match api.request_write_body(id, &[], None) {
 			Err(HttpError::Invalid) => {}