fix option decoding and add basic sanity test #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregdhill
force-pushed
the
fix-option-decoding
branch
from
a600dad to
fca9887
Compare
ascjones
reviewed
Sep 14, 2020
src/metadata.rs
Outdated
| modules_with_calls: HashMap<String, ModuleWithCalls>, | ||
| modules_with_events: HashMap<String, ModuleWithEvents>, | ||
| modules_with_errors: HashMap<String, ModuleWithErrors>, | ||
| pub(crate) modules: HashMap<String, ModuleMetadata>, |
Contributor
There was a problem hiding this comment.
Prefer to add a constructor rather than making all these pub(crate). Could probably just derive Default for your use case in the test.
Signed-off-by: Gregory Hill <[email protected]>
gregdhill
force-pushed
the
fix-option-decoding
branch
from
fca9887 to
08717eb
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gregory Hill [email protected]
The previous fix was not complete, we need to update the output bytes to indicate whether the
OptionisSomeorNone. I've also added a small test to validate this against the codec library.