Skip to content

Zero sized types #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ascjones merged 6 commits into from
Jun 8, 2020
Merged

Zero sized types #121

ascjones merged 6 commits into from
Jun 8, 2020

Conversation

@dvc94ch
Copy link
Contributor

@dvc94ch dvc94ch commented Jun 4, 2020

No description provided.

@dvc94ch dvc94ch force-pushed the zero-sized-types branch from 9e91517 to 414142e Compare June 4, 2020 22:51
@dvc94ch dvc94ch force-pushed the zero-sized-types branch from f6e0f43 to ca0d28c Compare June 6, 2020 10:16
@ascjones
Copy link
Contributor

ascjones commented Jun 8, 2020

Can you describe briefly what this fix was about?

@dvc94ch
Copy link
Contributor Author

dvc94ch commented Jun 8, 2020 •
edited
Loading

Using a zero sized type like () is ok, it's not an error. For our identity module, we set the System AccountData type to (). This causes with_system to fail because it tries to register AccountData with a zero value.

ascjones
ascjones reviewed Jun 8, 2020
View reviewed changes
ascjones
ascjones reviewed Jun 8, 2020
View reviewed changes
ascjones
ascjones approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ascjones ascjones merged commit 91203b9 into paritytech:master Jun 8, 2020
@ascjones ascjones mentioned this pull request Jun 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ascjones ascjones ascjones approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dvc94ch @ascjones