This repository was archived by the owner on Sep 19, 2019. It is now read-only.
fix(deser): fix indexing into str bug#62
Merged
Conversation
`str` consist of unicode characters which can be between 1-4 bytes long and indexing assuming that all are 1 byte may panic
niklasad1
force-pushed
the
fix-deserialize-str
branch
from
bb7e7dc to
dcd7571
Compare
tomusdrw
approved these changes
Feb 8, 2019
| if v.len() < 2 || &v[0..2] != "0x" { | ||
| // TODO: replace `v.starts_with("0x")` with `v.as_bytes()[0..2] != ['0' as u8, 'x' as u8] | ||
| // if `starts_with` is too slow | ||
| if v.len() < 2 || !v.starts_with("0x") { |
Contributor
There was a problem hiding this comment.
starts_with should suffice.
* Remove needless `len()` * Cast raw `u8` to char for more human-friendly error message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
str consist of unicode characters which can be between 1-4 bytes long and indexing assuming that all are 1 byte may panic