From aa82d7ef8b755bc97cba1a0d81092b8bf3dea102 Mon Sep 17 00:00:00 2001 From: adoerr <0xad@gmx.net> Date: Fri, 30 Apr 2021 16:09:26 +0200 Subject: [PATCH] Make KeyStore optional --- Cargo.lock | 8 ++++---- node/service/src/lib.rs | 18 +++++++++--------- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index c844baee1fe7..1f482a367ed8 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -458,7 +458,7 @@ checksum = "6736e2428df2ca2848d846c43e88745121a6654696e349ce0054a420815a7409" [[package]] name = "beefy-gadget" version = "0.1.0" -source = "git+https://github.com/paritytech/grandpa-bridge-gadget?branch=master#5726a43094cad395d6e253bbc8b93ff7e54f2453" +source = "git+https://github.com/paritytech/grandpa-bridge-gadget?branch=master#460ff08c8371958670d4075e1ba0551fab573757" dependencies = [ "beefy-primitives", "futures 0.3.14", @@ -486,7 +486,7 @@ dependencies = [ [[package]] name = "beefy-gadget-rpc" version = "0.1.0" -source = "git+https://github.com/paritytech/grandpa-bridge-gadget?branch=master#5726a43094cad395d6e253bbc8b93ff7e54f2453" +source = "git+https://github.com/paritytech/grandpa-bridge-gadget?branch=master#460ff08c8371958670d4075e1ba0551fab573757" dependencies = [ "beefy-gadget", "beefy-primitives", @@ -507,7 +507,7 @@ dependencies = [ [[package]] name = "beefy-primitives" version = "0.1.0" -source = "git+https://github.com/paritytech/grandpa-bridge-gadget?branch=master#5726a43094cad395d6e253bbc8b93ff7e54f2453" +source = "git+https://github.com/paritytech/grandpa-bridge-gadget?branch=master#460ff08c8371958670d4075e1ba0551fab573757" dependencies = [ "parity-scale-codec", "sp-api", @@ -4530,7 +4530,7 @@ dependencies = [ [[package]] name = "pallet-beefy" version = "0.1.0" -source = "git+https://github.com/paritytech/grandpa-bridge-gadget?branch=master#5726a43094cad395d6e253bbc8b93ff7e54f2453" +source = "git+https://github.com/paritytech/grandpa-bridge-gadget?branch=master#460ff08c8371958670d4075e1ba0551fab573757" dependencies = [ "beefy-primitives", "frame-support", diff --git a/node/service/src/lib.rs b/node/service/src/lib.rs index 13582d3d233c..34325e565cff 100644 --- a/node/service/src/lib.rs +++ b/node/service/src/lib.rs @@ -928,11 +928,19 @@ pub fn new_full( task_manager.spawn_essential_handle().spawn_blocking("babe", babe); } + // if the node isn't actively participating in consensus then it doesn't + // need a keystore, regardless of which protocol we use below. + let keystore_opt = if role.is_authority() { + Some(keystore_container.sync_keystore()) + } else { + None + }; + // We currently only run the BEEFY gadget on the Rococo and Wococo testnets. if chain_spec.is_rococo() || chain_spec.is_wococo() { let gadget = beefy_gadget::start_beefy_gadget::<_, beefy_primitives::ecdsa::AuthorityPair, _, _, _, _>( client.clone(), - keystore_container.sync_keystore(), + keystore_opt.clone(), network.clone(), beefy_link, network.clone(), @@ -949,14 +957,6 @@ pub fn new_full( } } - // if the node isn't actively participating in consensus then it doesn't - // need a keystore, regardless of which protocol we use below. - let keystore_opt = if role.is_authority() { - Some(keystore_container.sync_keystore()) - } else { - None - }; - let config = grandpa::Config { // FIXME substrate#1578 make this available through chainspec gossip_duration: Duration::from_millis(1000),