Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Mostly, let guide reflect #2579 #2583

Merged
eskimor merged 2 commits into from
Mar 9, 2021
Merged

Mostly, let guide reflect #2579 #2583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfa45a3
Statement distribution is now validator only.
eskimor Mar 9, 2021
83dd1d2
Avoid Arc creation where it is not necessarily needed.
eskimor Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions node/core/backing/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,10 +773,10 @@ impl CandidateBackingJob {
if self.seconded.is_none() {
// This job has not seconded a candidate yet.
let candidate_hash = candidate.hash();
let pov = Arc::new(pov);

if !self.issued_statements.contains(&candidate_hash) {
self.validate_and_second(&span, &candidate, pov.clone()).await?;
let pov = Arc::new(pov);
self.validate_and_second(&span, &candidate, pov).await?;
}
}
}
Expand Down
2 changes: 0 additions & 2 deletions roadmap/implementers-guide/src/node/backing/statement-distribution.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ Output:

Implemented as a gossip protocol. Handle updates to our view and peers' views. Neighbor packets are used to inform peers which chain heads we are interested in data for.

Statement Distribution is the only backing subsystem which has any notion of peer nodes, who are any full nodes on the network. Validators will also act as peer nodes.

It is responsible for distributing signed statements that we have generated and forwarding them, and for detecting a variety of Validator misbehaviors for reporting to [Misbehavior Arbitration](../utility/misbehavior-arbitration.md). During the Backing stage of the inclusion pipeline, it's the main point of contact with peer nodes. On receiving a signed statement from a peer, assuming the peer receipt state machine is in an appropriate state, it sends the Candidate Receipt to the [Candidate Backing subsystem](candidate-backing.md) to handle the validator's statement.

Track equivocating validators and stop accepting information from them. Establish a data-dependency order:
Expand Down