Upgrade litep2p to v0.12.0 and handle Kademlia publish success events#9685
Merged
Conversation
Contributor
Author
|
/cmd prdoc --bump major --audience node_dev |
lrubasze
approved these changes
Nov 18, 2025
Contributor
lrubasze
left a comment
lrubasze
left a comment
There was a problem hiding this comment.
Change looks good with some minor comment.
Also not sure about PR title - the change is not about bumping the version only.
| /// Start providing `key`. | ||
| pub async fn start_providing(&mut self, key: KademliaKey) { | ||
| self.kademlia_handle.start_providing(key.into()).await; | ||
| pub async fn start_providing(&mut self, key: KademliaKey) -> QueryId { |
Contributor
There was a problem hiding this comment.
We add here the return value.
Are there other places in the codebase which could be impacted with this?
Contributor
Author
There was a problem hiding this comment.
Nope, the only place this is called is in litep2p/mod.rs where we store the return value.
@lrubasze Thanks for the review!
dmitry-markin
changed the title
bkontur
added
the
A4-backport-stable2512
paritytech-release-backport-bot Bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
…#9685) litep2p v0.12.0 adds ability to track whether publishing a DHT record or provider was successful. This PR brings this functionality to substrate. Particularly, this fixes authority-discovery unnecessarily republishing DHT records due to litep2p not emitting `KademliaEvent::PutRecordSuccess` before v0.12.0. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit d38ac65)
|
Successfully created backport PR for |
EgorPopelyaev
added a commit
that referenced
this pull request
Nov 20, 2025
Backport #9685 into `stable2512` from dmitry-markin. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Dmitry Markin <dmitry@markin.tech> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: EgorPopelyaev <egor@parity.io>
github-project-automation
Bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
litep2p v0.12.0 adds ability to track whether publishing a DHT record or provider was successful. This PR brings this functionality to substrate. Particularly, this fixes authority-discovery unnecessarily republishing DHT records due to litep2p not emitting
KademliaEvent::PutRecordSuccessbefore v0.12.0.