Skip to content

Conversation

@dimartiro
Copy link
Contributor

Description

Adds a duplicate dependencies check as part of the CI checks

A duplicate dependency is the one that is present in both [dependencies] and [dev-dependencies] section

This PR depends on #9233 to solve all duplicates before start running the new check in future PRs

@dimartiro dimartiro requested review from a team as code owners July 22, 2025 00:39
@bkchr
Copy link
Member

bkchr commented Jul 22, 2025

@ggwpez maybe something that could be integrated into zepter?


This is useful for CI to enforce clean separation between runtime and dev-only dependencies.

A duplicated dependency is one that appears in both sections with the exact same configuration,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you mean with "exact same configuration"? Features? Or Version / Path stuff?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of that, same features, same path, same version, basically if we consider the dependency as

name = value

with "exact same configuration" I mean "same value"

@bkchr
Copy link
Member

bkchr commented Jul 22, 2025

@dimartiro I would then like to see this being integrated into zepter: ggwpez/zepter#150

So, for now I'm closing this pr and you can create a new one if you have done the upstream contribution. Ty!

@bkchr bkchr closed this Jul 22, 2025
@dimartiro
Copy link
Contributor Author

@dimartiro I would then like to see this being integrated into zepter: ggwpez/zepter#150

So, for now I'm closing this pr and you can create a new one if you have done the upstream contribution. Ty!

Yeah I think it's a better way to solve it! thanks for the suggestion

github-merge-queue bot pushed a commit that referenced this pull request Sep 26, 2025
# Description

This PR builds on my previous
[PR](#9233) and addresses
feedback from Basti’s comment
[here](#9283 (comment)).

To prevent the same situation from recurring in the future, I’ve
introduced a new **lint check** in **Zepter**, which is now also
integrated into the CI workflow. The purpose of this check is to
automatically detect and block cases where the same dependency is
declared both under `[dependencies]` and `[dev-dependencies]`.
bee344 pushed a commit that referenced this pull request Oct 7, 2025
# Description

This PR builds on my previous
[PR](#9233) and addresses
feedback from Basti’s comment
[here](#9283 (comment)).

To prevent the same situation from recurring in the future, I’ve
introduced a new **lint check** in **Zepter**, which is now also
integrated into the CI workflow. The purpose of this check is to
automatically detect and block cases where the same dependency is
declared both under `[dependencies]` and `[dev-dependencies]`.
alvicsam pushed a commit that referenced this pull request Oct 17, 2025
# Description

This PR builds on my previous
[PR](#9233) and addresses
feedback from Basti’s comment
[here](#9283 (comment)).

To prevent the same situation from recurring in the future, I’ve
introduced a new **lint check** in **Zepter**, which is now also
integrated into the CI workflow. The purpose of this check is to
automatically detect and block cases where the same dependency is
declared both under `[dependencies]` and `[dev-dependencies]`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants