Replace log with tracing on Snowbridge-related modules
#9279
Conversation
raymondkfcheung
changed the title
log with tracing on Bridge-related modules
prdoc/pr_9279.prdoc
Outdated
| crates: | ||
| - name: snowbridge-core | ||
| bump: minor | ||
| - name: snowbridge-ethereum |
There was a problem hiding this comment.
is snowbridge-ethereum needed here ? I don't see any changes
| @@ -0,0 +1,30 @@ | |||
| title: Replace `log` with `tracing` on Snowbridge-related modules | |||
There was a problem hiding this comment.
With regards to most of the crates here you're removing a dependency log and adding new one tracing. Should we consider this major level change due to removal of log ?
There was a problem hiding this comment.
I'm not sure. Previous PRs were marked as minor.
There was a problem hiding this comment.
minor or even patch are fine
# Conflicts: # bridges/snowbridge/pallets/ethereum-client/src/impls.rs
| let message = Self::prepare(message)?; | ||
|
|
||
| log::trace!(target: LOG_TARGET, "prepared message: {:?}", message); | ||
| tracing::trace!(target: LOG_TARGET, ?message, "prepared message"); |
There was a problem hiding this comment.
do we need a blank space after prepared message?
There was a problem hiding this comment.
I don't think so.
| bump: patch | ||
| - name: snowbridge-pallet-system-v2 | ||
| bump: patch | ||
| - name: snowbridge-runtime-common | ||
| bump: minor |
There was a problem hiding this comment.
dq: how do you distinguish between minor and patch in terms of this PR?
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for the link, I was not aware of it.
I looked at Validate prdoc for ... step in the link that you sent and checked the corresponding yml file with job definition; it uses check-prdoc.py underneath.
So I checked both: the script and yml job but could not find a piece of code responsible for bump validation.
Did I miss anything?
This PR replaces `log` with `tracing` instrumentation on Bridge Relay related modules by providing structured logging. Partially addresses #9211 Similar to #9279 ## Key Features - **Consistent targets**: All components use predictable log targets - **Structured fields**: Uses `?variable`/`%variable` syntax for automatic `Debug`/`Display` formatting - **Zero runtime impact**: No behavioural changes, only observability improvements --------- Co-authored-by: Andrii <[email protected]>
| @@ -0,0 +1,30 @@ | |||
| title: Replace `log` with `tracing` on Snowbridge-related modules | |||
There was a problem hiding this comment.
minor or even patch are fine
This PR replaces
logwithtracinginstrumentation in Snowbridge-related modules by providing structured logging.Partially addresses #9211
Similar to #8732
Key Features
?variable/%variablesyntax for automaticDebug/Displayformatting