Skip to content

Rewrite validator disabling test with zombienet-sdk #9128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexandruCihodaru merged 14 commits into from
Jul 21, 2025
Merged

Rewrite validator disabling test with zombienet-sdk #9128

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7d1ba0d
[tests]: Rewrite validator disabling test with zombienet-sdk
AlexandruCihodaru Jul 8, 2025
9410d01
Fix formatting and add prdoc
AlexandruCihodaru Jul 8, 2025
ff548e8
Fix clippy issues
AlexandruCihodaru Jul 8, 2025
b2bfdbf
Fix prdoc format
AlexandruCihodaru Jul 8, 2025
b76566e
Fix github workflow
AlexandruCihodaru Jul 8, 2025
954e369
Make malus validator vulnerable
AlexandruCihodaru Jul 10, 2025
6b3125e
add the id of the para in the error message
AlexandruCihodaru Jul 10, 2025
fae576a
Merge branch 'master' into acihodaru/9085-validator-disabling-to-zomb…
AlexandruCihodaru Jul 14, 2025
22aa406
Assert that the disabled validator is malus
AlexandruCihodaru Jul 15, 2025
9aa3c60
Merge branch 'master' into acihodaru/9085-validator-disabling-to-zomb…
AlexandruCihodaru Jul 17, 2025
d83d7b0
Merge branch 'master' into acihodaru/9085-validator-disabling-to-zomb…
AlexandruCihodaru Jul 17, 2025
3860df8
implement review feedback
AlexandruCihodaru Jul 17, 2025
0ca5341
make clippy happy
AlexandruCihodaru Jul 17, 2025
a793c13
Merge branch 'master' into acihodaru/9085-validator-disabling-to-zomb…
AlexandruCihodaru Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 29 additions & 28 deletions .github/workflows/zombienet_polkadot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,34 +229,6 @@ jobs:
build-id: ${{ needs.preflight.outputs.BUILD_RUN_ID }}
ref-slug: ${{ needs.preflight.outputs.SOURCE_REF_SLUG }}


#
zombienet-polkadot-functional-0010-validator-disabling:
needs: [preflight]
if: ${{ (needs.preflight.outputs.changes_substrate || needs.preflight.outputs.changes_polkadot) && ! contains(needs.preflight.outputs.FLAKY_TESTS, 'zombienet-polkadot-functional-0010-validator-disabling') }}
runs-on: ${{ needs.preflight.outputs.ZOMBIENET_LARGE_RUNNER }}
timeout-minutes: 60
container:
image: ${{ needs.preflight.outputs.ZOMBIENET_IMAGE }}
options: -v /tmp/zombienet:/tmp/zombienet
env:
ZOMBIENET_INTEGRATION_TEST_IMAGE: "${{ needs.preflight.outputs.TEMP_IMAGES_BASE }}/polkadot-debug:${{ needs.preflight.outputs.DOCKER_IMAGES_VERSION }}"
COL_IMAGE: "${{ needs.preflight.outputs.TEMP_IMAGES_BASE }}/colander:${{ needs.preflight.outputs.DOCKER_IMAGES_VERSION }}"
MALUS_IMAGE: "${{ needs.preflight.outputs.TEMP_IMAGES_BASE }}/malus:${{ needs.preflight.outputs.DOCKER_IMAGES_VERSION }}"
DEBUG: ${{ needs.preflight.outputs.DEBUG }}
ZOMBIENET_PROVIDER: ${{ needs.preflight.outputs.ZOMBIENET_PROVIDER }}
steps:
- name: Checkout
uses: actions/checkout@v4

- name: zombienet_test
uses: ./.github/actions/zombienet
with:
test: "0010-validator-disabling.zndsl"
local-dir: "${{ env.LOCAL_DIR }}/functional"
gh-token: ${{ secrets.GITHUB_TOKEN }}
build-id: ${{ needs.preflight.outputs.BUILD_RUN_ID }}
ref-slug: ${{ needs.preflight.outputs.SOURCE_REF_SLUG }}
#
#
zombienet-polkadot-functional-0013-systematic-chunk-recovery:
Expand Down Expand Up @@ -1024,6 +996,35 @@ jobs:
test: "functional::approved_peer_mixed_validators::approved_peer_mixed_validators_test"
prefix: "polkadot"

#
#
zombienet-polkadot-functional-validator-disabling:
needs: [preflight]
if: ${{ (needs.preflight.outputs.changes_substrate || needs.preflight.outputs.changes_polkadot) && ! contains(needs.preflight.outputs.FLAKY_TESTS, 'zombienet-polkadot-functional-0010-validator-disabling') }}
runs-on: ${{ needs.preflight.outputs.ZOMBIENET_LARGE_RUNNER }}
timeout-minutes: 60
container:
image: ${{ needs.preflight.outputs.ZOMBIENET_SDK_IMAGE }}
env:
POLKADOT_IMAGE: "${{ needs.preflight.outputs.TEMP_IMAGES_BASE }}/polkadot-debug:${{ needs.preflight.outputs.DOCKER_IMAGES_VERSION }}"
COL_IMAGE: "${{ needs.preflight.outputs.TEMP_IMAGES_BASE }}/colander:${{ needs.preflight.outputs.DOCKER_IMAGES_VERSION }}"
CUMULUS_IMAGE: "${{ needs.preflight.outputs.TEMP_IMAGES_BASE }}/polkadot-parachain-debug:${{ needs.preflight.outputs.DOCKER_IMAGES_VERSION }}"
MALUS_IMAGE: "${{ needs.preflight.outputs.TEMP_IMAGES_BASE }}/malus:${{ needs.preflight.outputs.DOCKER_IMAGES_VERSION }}"
RUST_LOG: ${{ needs.preflight.outputs.RUST_LOG }}
ZOMBIE_PROVIDER: ${{ needs.preflight.outputs.ZOMBIE_PROVIDER }}
steps:
- name: Checkout
uses: actions/checkout@v4

- name: zombienet_test
uses: ./.github/actions/zombienet-sdk
with:
gh-token: ${{ secrets.GITHUB_TOKEN }}
build-id: ${{ needs.preflight.outputs.BUILD_RUN_ID }}
ref-slug: ${{ needs.preflight.outputs.SOURCE_REF_SLUG }}
test: "functional::validator_disabling::validator_disabling_test"
prefix: "polkadot"

#
#
zombienet-polkadot-shared-core-idle-parachain:
Expand Down
81 changes: 39 additions & 42 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions polkadot/zombienet-sdk-tests/tests/functional/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ mod duplicate_collations;
mod shared_core_idle_parachain;
mod spam_statement_distribution_requests;
mod sync_backing;
mod validator_disabling;
Loading
Loading