From a0241700cd0d19171412b58552162f08eb0e3fa6 Mon Sep 17 00:00:00 2001 From: Iulian Barbu <14218860+iulianbarbu@users.noreply.github.com> Date: Wed, 11 Jun 2025 16:30:59 +0300 Subject: [PATCH] release/build-macos-binaries: add missing FEATURES argument (#8816) # Description In #8755 we enabled release scripts to build binaries with certain features too, used especially for `polkadot-omni-node`. I missed to add the `FEATURES` argument to the build script used for macos: https://github.com/paritytech/polkadot-sdk/pull/8755/files#diff-f4ebb5b55e4d2f4ec7ab5674ac3376839b13358d78935f9c388d79e75beeceb8R224 ## Integration N/A ## Review Notes This must be merged to be able to build `polkadot-omni-node` binary with runtime-benchmarks feature on macos. Fixed also the macos build per: https://github.com/paritytech/polkadot-sdk/pull/8815/commits/05502a350b5995c5b3386ef42bd608c88ec8f17c. --------- Signed-off-by: Iulian Barbu (cherry picked from commit 292368d05eec5d6649607251ab21ed2c96ebd158) --- .github/scripts/release/build-macos-release.sh | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/scripts/release/build-macos-release.sh b/.github/scripts/release/build-macos-release.sh index ba6dcc65d6509..4edb6746d73f5 100755 --- a/.github/scripts/release/build-macos-release.sh +++ b/.github/scripts/release/build-macos-release.sh @@ -14,12 +14,17 @@ PROFILE=${PROFILE:-production} # write, so make it relative to github workspace. ARTIFACTS=$GITHUB_WORKSPACE/artifacts/$BIN VERSION=$(git tag -l --contains HEAD | grep -E "^v.*") +# must be given as feature1,feature2,feature3... +FEATURES=$3 +if [ -n "$FEATURES" ]; then + FEATURES="--features ${FEATURES}" +fi echo "Artifacts will be copied into $ARTIFACTS" mkdir -p "$ARTIFACTS" git log --pretty=oneline -n 1 -time cargo build --profile $PROFILE --locked --verbose --bin $BIN --package $PACKAGE +time cargo build --profile $PROFILE --locked --verbose --bin $BIN --package $PACKAGE $FEATURES echo "Artifact target: $ARTIFACTS"