Skip to content

Fix reversed error message in DispatchInfo #7170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkchr merged 4 commits into from
Jan 15, 2025
Merged

Fix reversed error message in DispatchInfo #7170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7245a3
Fix reversed error message in weight-reclaim
skunert Jan 15, 2025
242f1ca
Update from skunert running command 'prdoc --bump patch --audience ru…
Jan 15, 2025
a77a24b
Merge branch 'master' into skunert/reclaim-fix-log-message
skunert Jan 15, 2025
1b9ffca
Apply suggestions from code review
bkchr Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions prdoc/pr_7170.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
title: Fix reversed error message in DispatchInfo
doc:
- audience: Runtime Dev
description: "Fix error message in `DispatchInfo` where post-dispatch and pre-dispatch\
\ weight was reversed.\r\n"
crates:
- name: frame-support
bump: patch
6 changes: 2 additions & 4 deletions substrate/frame/support/src/dispatch.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,10 +315,8 @@ impl PostDispatchInfo {
"Post dispatch weight is greater than pre dispatch weight. \
Pre dispatch weight may underestimating the actual weight. \
Greater post dispatch weight components are ignored.
Pre dispatch weight: {:?},
Post dispatch weight: {:?}",
actual_weight,
info_total_weight,
Pre dispatch weight: {info_total_weight:?},
Post dispatch weight: {actual_weight:?}",
);
}
actual_weight.min(info.total_weight())
Expand Down
Loading