diff --git a/prdoc/pr_10680.prdoc b/prdoc/pr_10680.prdoc new file mode 100644 index 0000000000000..f5befc3724686 --- /dev/null +++ b/prdoc/pr_10680.prdoc @@ -0,0 +1,7 @@ +title: 'revive: fix revive post_upgrade assert' +doc: +- audience: Runtime Dev + description: Fix post_upgrade assertion logic in revive v2 migration +crates: +- name: pallet-revive + bump: patch diff --git a/substrate/frame/revive/src/migrations/v2.rs b/substrate/frame/revive/src/migrations/v2.rs index 803283c6ab343..687adf6a5fd9a 100644 --- a/substrate/frame/revive/src/migrations/v2.rs +++ b/substrate/frame/revive/src/migrations/v2.rs @@ -184,10 +184,10 @@ impl SteppedMigration for Migration { "Migration failed: the number of items in the storage after the migration is not the same as before" ); - let deposit_sum: crate::BalanceOf = Zero::zero(); + let mut deposit_sum: crate::BalanceOf = Zero::zero(); for (code_hash, old_code_info) in prev_map { - deposit_sum.saturating_add(old_code_info.deposit); + deposit_sum = deposit_sum.saturating_add(old_code_info.deposit); Self::assert_migrated_code_info(code_hash, &old_code_info); }