Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xcm: fix for DenyThenTry Barrier #7169

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

xcm: fix for DenyThenTry Barrier #7169

wants to merge 26 commits into from
+485 −17

Conversation

yrong
Copy link
Contributor

@yrong yrong commented Jan 15, 2025 •
edited
Loading

Resolves: #7148

This PR changes the behavior of DenyThenTry from the pattern DenyIfAllMatch to DenyIfAnyMatch for the tuple.

I would expect the latter is the right behavior so make the fix in place, but we can also add a dedicated Impl with the legacy one untouched.

@yrong yrong requested a review from a team as a code owner January 15, 2025 02:43
@yrong yrong changed the title Fix for DenyThenTry xcm: fix for DenyThenTry Barrier Jan 15, 2025
@yrong yrong mentioned this pull request Jan 15, 2025
Open
2 tasks
@yrong yrong marked this pull request as draft January 15, 2025 03:36
bkontur
bkontur requested changes Jan 15, 2025
View reviewed changes
polkadot/xcm/xcm-executor/src/traits/should_execute.rs Show resolved Hide resolved
polkadot/xcm/xcm-executor/src/traits/should_execute.rs Show resolved Hide resolved
polkadot/xcm/xcm-builder/src/barriers.rs Outdated Show resolved Hide resolved
polkadot/xcm/xcm-builder/src/barriers.rs Outdated Show resolved Hide resolved
polkadot/xcm/xcm-builder/src/barriers.rs Outdated Show resolved Hide resolved
polkadot/xcm/xcm-executor/src/traits/should_execute.rs Outdated Show resolved Hide resolved
@bkontur
Copy link
Contributor

bkontur commented Jan 15, 2025

@yrong overall looks good so far, I was also thinking about another trait for that like this

@bkontur bkontur requested a review from x3c41a January 15, 2025 09:46
@yrong yrong marked this pull request as ready for review January 15, 2025 12:38
@franciscoaguirre franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Jan 15, 2025
franciscoaguirre
franciscoaguirre reviewed Jan 15, 2025
View reviewed changes
polkadot/xcm/xcm-executor/src/traits/should_execute.rs Outdated Show resolved Hide resolved
prdoc/pr_7169.prdoc Outdated Show resolved Hide resolved
@yrong yrong requested a review from bkontur January 15, 2025 16:06
@yrong yrong mentioned this pull request Jan 16, 2025
Draft
@bkontur bkontur mentioned this pull request Jan 16, 2025
Draft
5 tasks
@yrong yrong requested a review from bkontur January 17, 2025 02:53
bkontur
bkontur requested changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@bkontur bkontur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yrong please, check the last two:
https://github.com/paritytech/polkadot-sdk/pull/7169/files#r1919872067
https://github.com/paritytech/polkadot-sdk/pull/7169/files#r1919869399

@bkontur
Copy link
Contributor

bkontur commented Jan 17, 2025

/cmd fmt

@github-actions GitHub Actions
Copy link

Command "fmt" has started 🚀 See logs here

@github-actions GitHub Actions
Copy link

Command "fmt" has finished ✅ See logs here

bkontur
bkontur reviewed Jan 17, 2025
View reviewed changes
polkadot/xcm/xcm-builder/src/tests/barriers.rs Outdated Show resolved Hide resolved
polkadot/xcm/xcm-builder/src/tests/barriers.rs Outdated Show resolved Hide resolved
polkadot/xcm/xcm-builder/src/tests/barriers.rs Outdated Show resolved Hide resolved
polkadot/xcm/xcm-builder/src/tests/barriers.rs Outdated Show resolved Hide resolved
bkontur
bkontur approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@bkontur bkontur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscoaguirre franciscoaguirre franciscoaguirre left review comments

@bkontur bkontur bkontur approved these changes

@x3c41a x3c41a Awaiting requested review from x3c41a

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[XCM] Investigate better support for filtering XCM programs with Barrier
3 participants
@yrong @bkontur @franciscoaguirre