Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatxpool: add tests for rejecting invalid transactions #5477

Open
Tracked by #5472
michalkucharczyk opened this issue Aug 27, 2024 · 1 comment
Open
Tracked by #5472

fatxpool: add tests for rejecting invalid transactions #5477

michalkucharczyk opened this issue Aug 27, 2024 · 1 comment
Assignees
Labels
T0-node This PR/Issue is related to the topic “node”.

Comments

@michalkucharczyk
Copy link
Contributor

michalkucharczyk commented Aug 27, 2024

Unit tests for rejecting invalid transaction in different views configurations are required. Some improvements maybe required in ExternalWatcherContext::handle_invalidate_transaction.

@michalkucharczyk
Copy link
Contributor Author

I reviewed and added some tests in #6661.

This issue should still be open, while there is a niche corner case that needs to be handled:

//todo [#5477]
// - handle corner case: this may happen when tx is invalid for mempool, but somehow
// some view still sees it as ready/future. In that case we don't send the invalid
// event, as transaction can still be included. Probably we should set some flag here
// and allow for invalid sent from the view.
// - add debug / metrics,
false

This requires some rework: invalid transactions from view revalidation shall be sent to dropped_monitor_task and also force-removed from the view_store. After this we can safely send Invalid event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

No branches or pull requests

1 participant