Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not process already compiled PVFs in the session before entering active set #5125

Closed
AndreiEres opened this issue Jul 24, 2024 · 1 comment · Fixed by #5142
Closed

Do not process already compiled PVFs in the session before entering active set #5125

AndreiEres opened this issue Jul 24, 2024 · 1 comment · Fixed by #5142
Assignees
Labels
T0-node This PR/Issue is related to the topic “node”. T8-polkadot This PR/Issue is related to/affects the Polkadot network.

Comments

@AndreiEres
Copy link
Contributor

In #4791 we added logic for preparing PVFs if node is a validator in the next session. The implementation is ok for the entering the set for the first time, but then we can spend time on processing already prepared PVFs.

Quoting @sandreim #4791 (comment)

I think this just keeps decompressing needlessly if we are a validator intermittently: at session 1, then at session 2 we are no longer, but we are again at session 3.

All that was prepared for session 1 will be reset as soon as we go into session 2 (already_prepared_code_hashes is cleared). Is there a better way to check? Like query the PVF subsystem if it has it already ? Also I think the query needs to take into account the executor params which we are preparing with not just code hash.

@AndreiEres AndreiEres added T0-node This PR/Issue is related to the topic “node”. T8-polkadot This PR/Issue is related to/affects the Polkadot network. labels Jul 24, 2024
@AndreiEres AndreiEres self-assigned this Jul 24, 2024
@AndreiEres AndreiEres moved this from Backlog to Review in progress in parachains team board Jul 24, 2024
@AndreiEres AndreiEres moved this from Review in progress to In Progress in parachains team board Jul 24, 2024
@AndreiEres AndreiEres linked a pull request Aug 5, 2024 that will close this issue
@AndreiEres
Copy link
Contributor Author

This issue will no longer be relevant after #5142 has been merged

@github-project-automation github-project-automation bot moved this from Backlog to Completed in parachains team board Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T0-node This PR/Issue is related to the topic “node”. T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
Status: Completed
1 participant