More tests

Author: yrong

bridges/snowbridge/primitives/router/src/outbound/barriers.rs

@@ -100,27 +100,4 @@ mod tests {
 		);
 		assert!(result.is_ok());
 	}
-
-	#[test]
-	fn deny_with_reserve_transfer_to_relay_chain() {
-		let mut xcm: Vec<Instruction<()>> = vec![DepositReserveAsset {
-			assets: Wild(All),
-			dest: Location { parents: 1, interior: Here },
-			xcm: Default::default(),
-		}];
-
-		let result = DenyThenTry::<
-			DenyFirstExportMessageFrom<
-				EverythingBut<Equals<AssetHubLocation>>,
-				Equals<EthereumNetwork>,
-			>,
-			DenyThenTry<DenyReserveTransferToRelayChain, TakeWeightCredit>,
-		>::should_execute(
-			&AssetHubLocation::get(),
-			&mut xcm,
-			Weight::zero(),
-			&mut Properties { weight_credit: Weight::zero(), message_id: None },
-		);
-		assert_err!(result, ProcessMessageError::Unsupported);
-	}
 }

bridges/snowbridge/runtime/test-common/src/lib.rs

@@ -623,3 +623,56 @@ pub fn ethereum_to_polkadot_message_extrinsics_work<Runtime>(
 			assert_ok!(sync_committee_outcome);
 		});
 }
+
+#[allow(clippy::too_many_arguments)]
+pub fn send_transfer_token_message_from_source_other_than_asset_hub_failure<Runtime, XcmConfig>(
+	ethereum_chain_id: u64,
+	collator_session_key: CollatorSessionKeys<Runtime>,
+	runtime_para_id: u32,
+	assethub_parachain_id: u32,
+	another_parachain_id: u32,
+	initial_amount: u128,
+	weth_contract_address: H160,
+	destination_address: H160,
+	fee_amount: u128,
+	expected_error: XcmError,
+) where
+	Runtime: frame_system::Config
+		+ pallet_balances::Config
+		+ pallet_session::Config
+		+ pallet_xcm::Config
+		+ parachain_info::Config
+		+ pallet_collator_selection::Config
+		+ cumulus_pallet_parachain_system::Config
+		+ snowbridge_pallet_outbound_queue::Config
+		+ snowbridge_pallet_system::Config
+		+ pallet_timestamp::Config,
+	XcmConfig: xcm_executor::Config,
+	ValidatorIdOf<Runtime>: From<AccountIdOf<Runtime>>,
+{
+	ExtBuilder::<Runtime>::default()
+		.with_collators(collator_session_key.collators())
+		.with_session_keys(collator_session_key.session_keys())
+		.with_para_id(runtime_para_id.into())
+		.with_tracing()
+		.build()
+		.execute_with(|| {
+			<snowbridge_pallet_system::Pallet<Runtime>>::initialize(
+				runtime_para_id.into(),
+				assethub_parachain_id.into(),
+			)
+			.unwrap();
+
+			// fund asset hub sovereign account enough so it can pay fees
+			initial_fund::<Runtime>(assethub_parachain_id, initial_amount);
+
+			let outcome = send_transfer_token_message::<Runtime, XcmConfig>(
+				ethereum_chain_id,
+				another_parachain_id,
+				weth_contract_address,
+				destination_address,
+				fee_amount,
+			);
+			assert_err!(outcome.ensure_complete(), expected_error);
+		});
+}

cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/tests/snowbridge.rs

@@ -20,13 +20,15 @@ use bp_asset_hub_westend::ASSET_HUB_WESTEND_PARACHAIN_ID;
 use bp_bridge_hub_westend::BRIDGE_HUB_WESTEND_PARACHAIN_ID;
 use bp_polkadot_core::Signature;
 use bridge_hub_westend_runtime::{
-	bridge_to_rococo_config, xcm_config::XcmConfig, AllPalletsWithoutSystem,
-	BridgeRejectObsoleteHeadersAndMessages, Executive, MessageQueueServiceWeight, Runtime,
-	RuntimeCall, RuntimeEvent, SessionKeys, TxExtension, UncheckedExtrinsic,
+	bridge_to_rococo_config,
+	xcm_config::{Barrier, XcmConfig},
+	AllPalletsWithoutSystem, BridgeRejectObsoleteHeadersAndMessages, Executive,
+	MessageQueueServiceWeight, Runtime, RuntimeCall, RuntimeEvent, SessionKeys, TxExtension,
+	UncheckedExtrinsic,
 };
 use codec::{Decode, Encode};
 use cumulus_primitives_core::XcmError::{FailedToTransactAsset, NotHoldingFees};
-use frame_support::parameter_types;
+use frame_support::{assert_err, parameter_types, traits::ProcessMessageError};
 use parachains_common::{AccountId, AuraId, Balance};
 use snowbridge_pallet_ethereum_client::WeightInfo;
 use sp_core::H160;
@@ -35,9 +37,15 @@ use sp_runtime::{
 	generic::{Era, SignedPayload},
 	AccountId32,
 };
+use xcm::prelude::{
+	All, AssetFilter, DepositReserveAsset, Here, Instruction, Location, Parachain, Weight, Wild,
+	XcmError,
+};
+use xcm_executor::traits::{Properties, ShouldExecute};
 
 parameter_types! {
 		pub const DefaultBridgeHubEthereumBaseFee: Balance = 2_750_872_500_000;
+		pub AssetHubLocation: Location = Location::new(1, Parachain(ASSET_HUB_WESTEND_PARACHAIN_ID));
 }
 
 fn collator_session_keys() -> bridge_hub_test_utils::CollatorSessionKeys<Runtime> {
@@ -200,3 +208,36 @@ fn construct_and_apply_extrinsic(
 	let r = Executive::apply_extrinsic(xt);
 	r.unwrap()
 }
+
+#[test]
+pub fn transfer_token_to_ethereum_from_source_other_than_asset_hub_failure() {
+	snowbridge_runtime_test_common::send_transfer_token_message_from_source_other_than_asset_hub_failure::<Runtime, XcmConfig>(
+		11155111,
+		collator_session_keys(),
+		BRIDGE_HUB_WESTEND_PARACHAIN_ID,
+		ASSET_HUB_WESTEND_PARACHAIN_ID,
+		2000,
+		DefaultBridgeHubEthereumBaseFee::get(),
+		H160::random(),
+		H160::random(),
+		DefaultBridgeHubEthereumBaseFee::get(),
+		XcmError::Barrier,
+	)
+}
+
+#[test]
+fn deny_reserve_transfer_to_relay_chain() {
+	let mut xcm: Vec<Instruction<()>> = vec![DepositReserveAsset {
+		assets: AssetFilter::try_from(Wild(All)).unwrap(),
+		dest: Location { parents: 1, interior: Here },
+		xcm: Default::default(),
+	}];
+
+	let result = Barrier::should_execute(
+		&AssetHubLocation::get(),
+		&mut xcm,
+		Weight::zero(),
+		&mut Properties { weight_credit: Weight::zero(), message_id: None },
+	);
+	assert_err!(result, ProcessMessageError::Unsupported);
+}